Initialize CounterCheckOrch with port information after QueueMaps initialization #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I notice the syslog message is lacking the complete info. Since you mentioned "Otherwise CounterCheckOrch is not properly initialized", could you add more try-catch and logging for all kinds of risks? |
|
retest this please |
lguohan
approved these changes
Jun 29, 2018
lguohan
pushed a commit
that referenced
this pull request
Jun 30, 2018
…tialization (#528) * Pospone QueueMap initialization until activation of counters * Initialize CounterCheckOrch after we initialized the QueueMaps
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
…get_availability (sonic-net#528) * Add sai_object_type_get_availability to libsairedis * Add handler for sai_object_type_get_availability to syncd * Add sai_object_type_get_availability implementation to virtual switch Signed-off-by: Danny Allen <daall@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Postpone initialization of CounterCheckOrch until we have all required information
Why I did it
Otherwise CounterCheckOrch is not properly initialized
How I verified it
Build a new image and try on your DUT
Details if related